resources
xaraya core checkbox property broken
Posted by: Jo on July 13, 2008 | Updated: August 6, 2008 06:14 PM
I finally managed to get the intermin xarTinyMCE finished and propagated to the Xaraya Module repository branch. It should tide most over until the full rewrite.
I thought everything was well and working until i setup xarTInyMCE in Xaraya Core to test after doing some manual merging. It was then i realized that the xaraya dynamic data checkbox property was broken. This also means xarTinyMCE running on xaraya core has broken config settings until the DD checkbox fix is applied.
We've been running on Xarigami Core for quite a while and I'd not noticed that the code was broken in Xaraya Core. We've been using checked="checked" for checkbox true, although the core also takes the more recent addition of value="1" to signify a value of true for checkbox. In Xaraya Core this is broken and only recognizes the value="1" syntax.
I pushed the fix for this to Xaraya core, which is a change in modules/base/xarproperties/Dynamic_Checkbox_Property.php at line 70:
$data['checked'] = (isset($data['value']) && $data['value']) || (isset($data['checked']) && $data['checked']) ? true : false;
should be changed to:
data['checked'] = (isset($value) && $value) || (isset($checked) && $checked) ? true : false;
Related project : xartinymce
| « prev | next» |